Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Added .editorconfig - #6164

Merged
Hainish merged 1 commit into
EFForg:masterfrom
luixxiul:editorconfig
Aug 12, 2016
Merged

Hainish merged 1 commit into
EFForg:masterfrom
luixxiul:editorconfig

Conversation

@luixxiul

@luixxiul luixxiul commented Aug 9, 2016

Copy link
Copy Markdown
Contributor

Closes #5837

cc: @fuglede, @J0WI, @Hainish

@Hainish

Hainish commented Aug 12, 2016

Copy link
Copy Markdown
Member

Neat!

@Hainish
Hainish merged commit eaad0d0 into EFForg:master Aug 12, 2016
@luixxiul

Copy link
Copy Markdown
Contributor Author

Should indent-size be 8? /cc: @Hainish

@Hainish

Hainish commented Aug 13, 2016

Copy link
Copy Markdown
Member

I think 4 is fine for the xml indentation

@luixxiul

Copy link
Copy Markdown
Contributor Author

It seems to me that the tab size became smaller because of the setting from this to this. Let me know if it is not good.

@Hainish

Hainish commented Aug 13, 2016

Copy link
Copy Markdown
Member

That probably depends on your editors previous setting. One thing we could do is leave it unspecified, and that way indentation will be tabs but we won't be prescriptive in how that's displayed in the editors of our contributors.

@luixxiul

Copy link
Copy Markdown
Contributor Author

OK got it, thanks.

@Hainish

Hainish commented Aug 13, 2016

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants